fix: initialization error for WrappedChatComponent on 1.20.4-1.21.5#3493
Merged
dmulloy2 merged 1 commit intodmulloy2:masterfrom Jun 27, 2025
Merged
Conversation
The ComponentSerialization class also exists on these versions, so the MinecraftReflection#getChatSerializerClass method would return a class that does not contain the expected methods, hence failing initialization. This commit changes the lookup order, so that the subclasses are searched before the ComponentSerialization class. Closes dmulloy2#3478 Closes dmulloy2#3482 Closes dmulloy2#3488
Contributor
Author
|
I'm not sure if this is the preferred way to fix it. I think a better option would be to treat these as two different classes and add a new method to |
dmulloy2
approved these changes
Jun 27, 2025
Owner
|
makes sense to me. thank you! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ComponentSerialization class also exists on these versions, so the MinecraftReflection#getChatSerializerClass method would return a class that does not contain the expected methods, hence failing initialization.
This commit changes the lookup order, so that the subclasses are searched before the ComponentSerialization class.
Closes #3478
Closes #3482
Closes #3488